No Support for Compile Time DI with Play 2.4

[loicdescotte]

Hi,
Play 2.4 supports both runtime and compile time dependency injection.
As CommonsMailer uses @Inject it seems impossible to use it without the Guice container.
It would be nice to provide a trait that provide a "raw" mailer client and that could be mixed in Play's BuiltInComponentsFromContext to support compile time DI, like this WS Component for example.

Thanks

Loïc

[ggrossetie]

Hi @loicdescotte,

With this pull request, you will be able to manually create a mailer client:

val email = Email("Simple email", "Mister FROM <[email protected]>")
new SMTPMailer(SMTPConfiguration("typesafe.org", 1234)).send(email)

AFAIK NingWS also use @Inject, for example in the NingWSAPI constructor (i.e. the dependency on Guice is provided by Play!). So basically we just need to create a trait ?

trait MailerComponents {

  def configuration: Configuration

  lazy val mailerClient = new SMTPMailer(new SMTPConfigurationProvider(configuration).get())
}

Having said that, we still need to sort out how to let user provide their own SMTPConfiguration and how to provide multiple mailer clients (for other email service providers as requested in #10)

[loicdescotte]

@Mogztter great, I hope it will be merged :)
Indeed I guess we just need to create a trait like this one.

[ggrossetie]

Resolved by #70