Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a modal dialog box for documentation warnings #200

Open
wsargent opened this issue Mar 19, 2018 · 3 comments
Open

Use a modal dialog box for documentation warnings #200

wsargent opened this issue Mar 19, 2018 · 3 comments

Comments

@wsargent
Copy link
Member

There are several warning notices that kick into action on the site:

https://www.playframework.com/documentation/2.5.x/Home: "You are viewing the documentation for the 2.5.x release series. The latest stable release series is 2.6.x."

https://www.playframework.com/documentation/1.4.x/home: "You are viewing the documentation for Play 1. The documentation for Play 2 is here."

These warning are above the search bar, and have visual styling that is hard to distinguish from the rest of the page. It would be better to turn this into a modal dialog that covers the rest of the page and must be explicitly clicked through and ignored (potentially with cookie for persistent setting) so that it can't be skipped past.

@marcospereira
Copy link
Member

I think we can go the Akka way here:

  1. For non-supported versions: https://doc.akka.io/docs/akka/2.4.10/scala.html
  2. For outdated versions: https://doc.akka.io/docs/akka/2.5.1/scala.html

What do you think?

@eed3si9n
Copy link

FYI @xuwei-k reported on Twitter (https://twitter.com/xuwei_k/status/1041313148035203073) about a new user in Japan following Play 2.4 guide and doing:

$ activator new my-first-app play-scala

Having the banner would've helped I think.

@eed3si9n
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants