Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPY button in document code section would move along with the scroll bar #579

Open
dongxuwang opened this issue Jan 11, 2024 · 7 comments

Comments

@dongxuwang
Copy link

dongxuwang commented Jan 11, 2024

For example, in this page: https://www.playframework.com/documentation/3.0.x/ScalaActions

Right above the section "Controllers are action generators", you might see that COPY button in the right corner of the code box would move if scrollbar move

ScreenRecording2024-01-11at23 26 51-ezgif com-video-to-gif-converter

@mkurz
Copy link
Member

mkurz commented Jan 15, 2024

@dongxuwang Do you want to provide a pull request to fix that?

@dongxuwang
Copy link
Author

@dongxuwang Do you want to provide a pull request to fix that?

Looks like this is not easy.

I could not even find where to fix the css.

In here, it might be related to omnidoc which, I found, is an empty sbt project.

@mkurz can you give some advice about where I can fix?

@mkurz
Copy link
Member

mkurz commented Mar 12, 2024

@dongxuwang Actually you can run the documention locally by cloning this repository and then

cd documentation
sbt run

The docs can be found here: https://github.com/playframework/playframework/tree/main/documentation and the css is in the styles folder in there.

@pckrishnadas88
Copy link

pckrishnadas88 commented Apr 13, 2024

@mkurz as per the latest main branch I cannot see the copy button when I executed sbt run locally. Is that removed from source code?

Screenshot 2024-04-13 at 6 15 33 PM

@mkurz
Copy link
Member

mkurz commented Apr 13, 2024

No it's not removed. Maybe in dev mode locally it does not show up because of how things are configured or maybe CSP kicks in and blocks a js file.

@pckrishnadas88
Copy link

@mkurz If you could guide me through how to enable those buttons locally I will try to fix this issue. I'm currently on mac m1.

Thank you

@pckrishnadas88
Copy link

pckrishnadas88 commented Apr 14, 2024

@mkurz added a PR for this kindly verify playframework/playframework#12533 #578

@mkurz mkurz transferred this issue from playframework/playframework Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants