Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compileVirtual should not depend on File object to template #143

Open
unoexperto opened this issue Sep 7, 2017 · 1 comment
Open

compileVirtual should not depend on File object to template #143

unoexperto opened this issue Sep 7, 2017 · 1 comment
Labels
status:backlog

Comments

@unoexperto
Copy link

I think TwirlCompiler.compileVirtual should not depend on File object to template because internally it's used only to generate template name. This prevent clients from compiling twirl templates on the fly. In my case I'd like admins of web-service to be able to update templates via API which are stored in DB.
@mkurz
Copy link
Member

mkurz commented Sep 7, 2017

@unoexperto How about a pull request? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dwijnand @mkurz @unoexperto