From 230880c092c7c67c867bbc60c6bcbf0882460a9c Mon Sep 17 00:00:00 2001
From: Mikhail Sandakov <msandakov@plesk.com>
Date: Wed, 20 Mar 2024 10:48:46 +0200
Subject: [PATCH] Check if all required services are startable, not just exists

---
 src/systemd.py | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/systemd.py b/src/systemd.py
index c777d06..586ba45 100644
--- a/src/systemd.py
+++ b/src/systemd.py
@@ -26,29 +26,34 @@ def is_service_active(service: str):
 
 def get_required_services(service: str) -> typing.List[str]:
     res = subprocess.run(
-        [SYSTEMCTL_BIN_PATH, 'cat', service],
+        [SYSTEMCTL_BIN_PATH, 'show', '--property', 'Requires', service],
         stdout=subprocess.PIPE,
         stderr=subprocess.PIPE,
         check=True,
         universal_newlines=True
     )
 
-    required_services = []
-    for line in res.stdout.splitlines():
-        if line.startswith('Requires='):
-            required_services = line.split('s=')[1].split()
-            break
+    required_services = [service for service in res.stdout.split('s=')[1].split() if '.service' in service]
     return required_services
 
 
-def is_service_can_be_started(service: str) -> bool:
+def is_service_startable(service: str, already_checked: typing.Set[str] = None) -> bool:
     if not is_service_exists(service):
+        log.debug(f"Service '{service}' not exists")
         return False
 
+    if already_checked is not None and service in already_checked:
+        return True
+
+    if already_checked is None:
+        already_checked = {service}
+    else:
+        already_checked.add(service)
+
     required_services = get_required_services(service)
     for required_service in required_services:
-        if not is_service_exists(required_service):
-            log.debug("Service '{}' can't be started because required service '{}' doesn't exist".format(service, required_service))
+        if not is_service_startable(required_service, already_checked):
+            log.debug(f"Service '{service}' can't be started because required service '{required_service}' doesn't startable")
             return False
     return True