Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A conversation's __getitem__ returns None on invalid key? #123

Open
jaroel opened this issue May 11, 2017 · 0 comments
Open

A conversation's __getitem__ returns None on invalid key? #123

jaroel opened this issue May 11, 2017 · 0 comments

Comments

@jaroel
Copy link
Member

jaroel commented May 11, 2017 •
edited by gforcada
Loading

The __getitem__ implementation of Conversation currently returns None if an invalid key is passed in.
I would expect this to raise a KeyError instead. Is this intended behavior?

See https://github.com/plone/plone.app.discussion/blob/master/plone/app/discussion/conversation.py#L211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaroel