Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing HTML id for the comments section #72

Open
keul opened this issue Jul 21, 2015 · 5 comments
Open

Missing HTML id for the comments section #72

keul opened this issue Jul 21, 2015 · 5 comments

Comments

@keul
Copy link
Member

keul commented Jul 21, 2015

The comments template is missing of a unique HTML id for the comments section at

.

We have only a unique id for the comments form (commenting).

In this way is not possible to directly link a Plone document#comments

@keul
Copy link
Member Author

keul commented Jul 21, 2015

... I can provide a pull request with that change if needed.

@tisto
Copy link
Sponsor Member

tisto commented Jul 21, 2015

It should set an id attribute here:

@tisto tisto closed this as completed Jul 21, 2015
@keul
Copy link
Member Author

keul commented Jul 22, 2015

@tisto this is not what I meant, that id is related to a single comment and is impossible to be know before the comment has been inserted, and is different in every page. Thant's ok, but not usable
for create link like http://mysite/mypage#comments

@tisto
Copy link
Sponsor Member

tisto commented Jul 22, 2015

Sorry if I misunderstood your issue. So you just want to add one single #comments anchor to the template? I would be perfecly ok with doing that.

@keul
Copy link
Member Author

keul commented Jul 22, 2015

@tisto yes, exactly.

I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants