Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order layout panel should be enabled only when we are focused on that panel #6492

Open
ichim-david opened this issue Nov 19, 2024 · 4 comments

Comments

@ichim-david
Copy link
Member

Describe the bug
The order side panel is rendering even when it's the order button isn't focused.
We should enable it only when we want to interact with it as it's another set of elements that re-render every time
there is a change in the blocks within the page.
To Reproduce
Steps to reproduce the behavior:
Use devtools to see the order panel logic rendered even when you don't intend to interact with it because your focus
is on the page options or a certain focused block.

Expected behavior
Order panel should render only when focused.

@plone plone deleted a comment from Deathnote45 Nov 19, 2024
@plone plone deleted a comment from ichim-david Nov 19, 2024
@ichim-david
Copy link
Member Author

ichim-david commented Nov 25, 2024

@stevepiercy don't delete my comments please when I tell to these individuals that they need to follow the rules of contribution, perhaps if it weren't deleted I wouldn't have now 2 comments from @saurabhraghuvanshii and @kaushik7kk asking me if they can work on this issue.

To answer to you guys I don't think any of you should work on this issue since you clearly have not followed the rules and expectations that we have for first time contributors https://6.docs.plone.org/contributing/first-time.html

@stevepiercy
Copy link
Collaborator

@ichim-david we discussed already that we want a clean comment history, and not scroll through noise. I used to leave my own admonitions, but they were ignored repeatedly. Going forward, we can leave the first admonition and delete the rest.

However in all of my experience, those who post a comment such as the one above don't read anything except the title, and maybe the description, of the issue. That's why I have https://docs.github.com/en/get-started/writing-on-github/working-with-saved-replies/creating-a-saved-reply to make it easier to admonish such inconsiderate behavior. I almost never bother to personalize these messages because they don't bother to read a readme or contributing guide. Here's the one I use most often, and I delete the Volto bit for other repos.

please read and follow [First-time contributors](https://6.docs.plone.org/contributing/first-time.html), especially [Things not to do](https://6.docs.plone.org/contributing/first-time.html#things-not-to-do), [Contributing to Plone](https://6.docs.plone.org/contributing/index.html), and [Contributing to Volto](https://6.docs.plone.org/contributing/volto.html).

@nitinawari
Copy link

@ichim-david As I understand it, you're saying that when we open the layout tab, it currently defaults to rendering the order tab inside instead of the block tab. Are you suggesting that we should render the block tab by default instead of the order tab? Please let me know if I misunderstood

@ichim-david
Copy link
Member Author

@nitinawari no. What I mean is this, the order tab renders it's content which is a drag and drop list of blocks that mirrors the drag and drop seen on the main edit area.
The order Component should only be rendered when the Order tab is activated, otherwise it should return null or '' so that it doesn't influence the performance of the editing interface since again it mirrors the editing interface blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants