-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More than 10x slowdown with 1.0.0rc0
.
#231
Comments
I'm assuming it does something like open a new copy of chrome for each image. |
Yeah, that's the issue. I want to upgrade the API soon and deprecate this one. @s-banach, are you comfortable using |
Yes! |
Alright, give me an hour or two and I"ll write and test a quickstart- it should make its way in to the README as well.... |
Hey, @s-banach, some news: Basically the That said, I pushed a branch (https://github.com/plotly/Kaleido/tree/andrew/factor_for_faster) which allows you to run code like this: from choreographer import
import kaleido
async with Browser() as browser:
spec = scope.make_spec(fig, format="png") # serializes figure
binary = await kaleido.to_image_w_browser(spec, browser)
# something to write the binary to a file, async better I used a blocking image write but still got 2.5X - it only uses one browser. You can also wait for kaleido2 if you don't want to use a branch and this and it'll have a nice API, it's going to be a weekend sprint. Sorry for the delay! |
Simple test script:
Time with
0.1.0.post1
:0.95 seconds
Time with
1.0.0rc0
:10.78 seconds
The text was updated successfully, but these errors were encountered: