Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github - use the GithubApiClient class / get rid of external dependency #36

Open
pmauduit opened this issue May 10, 2022 · 0 comments
Open

github - use the GithubApiClient class / get rid of external dependency #36

pmauduit opened this issue May 10, 2022 · 0 comments

Comments

@pmauduit
Copy link
Owner

I am still using github-api as external dependency (https://github.com/pmauduit/slack-bot/blob/master/pom.xml#L151-L155). Since we are only doing some basic API calls, one could use the GithubApiClient class instead.

Also the class GithubListener is doing a lot of github api logic by itself, and could rely more onto the previously mentioned one.
pmauduit added a commit that referenced this issue May 10, 2022
@pmauduit
github - implements a "action" command (#25)
baa3516 
Lacks some unit testing (esp. on the parsing date/time topic), but does
the job already.

The code still requires a bit of refactoring, which will be the purpose
of #36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmauduit