Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When .glb file does not exist (or path is wrong), command still adds .jsx file to repo #184

Open
dataseyo opened this issue Jan 26, 2023 · 3 comments
Open

When .glb file does not exist (or path is wrong), command still adds .jsx file to repo #184

dataseyo opened this issue Jan 26, 2023 · 3 comments

Comments

@dataseyo
Copy link

If you try to run the command on a file that doesn't exist, or if you get the path wrong, you get an empty .jsx file in your repository. This seems like undesirable behavior and I'm sure I could implement a quick fix. Is it okay if I submit a PR?
@drcmda
Copy link
Member

drcmda commented Jan 26, 2023

sure!

@dataseyo dataseyo mentioned this issue Jan 27, 2023
Open
@dataseyo
Copy link
Author

dataseyo commented Jan 27, 2023 •
edited
Loading

Forked the repo and submitted a pr #185

@dataseyo
Copy link
Author

@drcmda just wanted to send a gentle nudge that I resolved the empty file issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drcmda @dataseyo