Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hey @Sean-Bradley, a few observations: #502

Open
RonBonBon opened this issue May 27, 2024 · 1 comment
Open

Hey @Sean-Bradley, a few observations: #502

RonBonBon opened this issue May 27, 2024 · 1 comment

Comments

@RonBonBon
Copy link

Hey @Sean-Bradley, a few observations:

  • what's the problem with buttons being recreated on each render? Is there some scaling issue that I'm not aware of?
  • there's no problem with bypassing the exhaustive-deps lint rule in general, as long as you know what you're doing. We actually do that a lot in Leva 🤧

However, here the solution to your problem is pretty obvious:

 const buttons = useMemo(() => {
     const _buttons = {}
    positions.forEach((p, i) => {
      _buttons['button ' + i] = button(() => setTo(p))
    })
   return _buttons
  }, [positions, setTo])

And if you're a fan of the reduce function:

 const buttons = useMemo(() => positions.reduce((acc, p, i) =>
  Object.assign(acc, { [`button ${i}`]: button(() => setTo(p)) }), {}), [positions, setTo])

Originally posted by @dbismut in #393 (comment)

@Sean-Bradley
Copy link

Sean-Bradley commented May 27, 2024

It seems you have created a new issue from an issue that was already solved and closed.
#393 (comment)

Your problem is unclear because this is a verbatim copy of just one of the comments from the original thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants