New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eigen decomposition required for bvec averaging #22

Open

tashrifbillah opened this issue May 5, 2021 · 0 comments

Collaborator

tashrifbillah commented May 5, 2021 •

edited

Loading

bvec averaging may not be correct, should be done based on eigen decomposition:

conversion/conversion/grad_avg.py

Lines 67 to 70 in 48f94ce

    
               print('Averaging gradients: ', ind_same) 
        
           data_new.append(np.mean(data[...,ind_same], axis= 3)) 
        
           temp= np.mean(bvecs[ind_same], axis= 0) 
        
           bvecs_new.append(temp/np.linalg.norm(temp))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment