Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pci equation incorrect #1390

Closed
weilixu opened this issue Jun 23, 2024 · 3 comments
Closed

pci equation incorrect #1390

weilixu opened this issue Jun 23, 2024 · 3 comments
Assignees
@jugonzal07 @yunjoonjung-PNNL

Comments

@weilixu
Copy link
Collaborator

weilixu commented Jun 23, 2024

This equation https://github.com/pnnl/ruleset-checking-tool/blob/master/rct229/rulesets/ashrae9012019/section1/section1rule3.py#L115
is incorrect. It is missing a bracket to do the sum first before division.
It will need update both in rule definition @yunjoonjung-PNNL and test files @jugonzal07
@yunjoonjung-PNNL yunjoonjung-PNNL mentioned this issue Jun 24, 2024
Merged
@yunjoonjung-PNNL
Copy link
Collaborator

yunjoonjung-PNNL commented Jun 24, 2024 •
edited
Loading

Good catch!

I made a draft PR (#1391). I'd appreciate it if @jugonzal07 could update the testing JSON file in this PR. Thank you!

@JacksonJ-KC
Copy link
Collaborator

I am currently making updates to the TCD spreadsheet and will make these updates too.

@JacksonJ-KC JacksonJ-KC changed the title pbi equation incorrect pci equation incorrect Jul 5, 2024
@JacksonJ-KC
Copy link
Collaborator

I made updates to the rule tests, and I pushed the updated test json for rule 1-3 to #1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jugonzal07 jugonzal07

@yunjoonjung-PNNL yunjoonjung-PNNL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jugonzal07 @weilixu @yunjoonjung-PNNL @JacksonJ-KC