From 6173f281d0eb1c405a8bac709108ed737b553234 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Wed, 11 Sep 2024 19:56:39 -0400 Subject: [PATCH 1/7] Updated ashrae229 schema and json pointer enumerations to get things going for section 11 --- .../scripts/resources/json_pointer_enumerations.json | 4 +++- rct229/schema/ASHRAE229.schema.json | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json b/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json index 7fb6882b78..6aa3f61659 100644 --- a/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json +++ b/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json @@ -22,8 +22,10 @@ "output_validation_points": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/terminals[0]/fan/output_validation_points", "preheat_system": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/preheat_system", "pumps": "ruleset_model_descriptions[0]/pumps", - "sensible_cool_capacity": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/cooling_system/sensible_cool_capacity", "schedules": "ruleset_model_descriptions[0]/schedules", + "sensible_cool_capacity": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/cooling_system/sensible_cool_capacity", + "service_water_heating_distribution_systems": "ruleset_model_descriptions[0]/service_water_heating_distribution_systems", + "service_water_piping":"ruleset_model_descriptions[0]/service_water_heating_distribution_systems[0]/service_water_piping", "spaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces", "subsurfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces[0]/subsurfaces", "surfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces", diff --git a/rct229/schema/ASHRAE229.schema.json b/rct229/schema/ASHRAE229.schema.json index cfc9c6932c..2a9afb42dc 100644 --- a/rct229/schema/ASHRAE229.schema.json +++ b/rct229/schema/ASHRAE229.schema.json @@ -4225,6 +4225,10 @@ "is_recirculation_loop": { "description": "Indicates if service water heating piping is a loop and recirculates", "type": "boolean" + }, + "are_thermal_losses_modeled": { + "description": "Indicates if thermal losses from the service water heating piping are modeled", + "type": "boolean" }, "insulation_thickness": { "description": "Pipe insulation thickness", From ce9e82bd03aa0d0e7534ae21dbcd3240c9721692 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Wed, 11 Sep 2024 19:58:59 -0400 Subject: [PATCH 2/7] First cut at rule test 11-6 --- .../ashrae9012019/section11/rule_11_6.json | 131 ++++++++++++++++++ 1 file changed, 131 insertions(+) create mode 100644 rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json new file mode 100644 index 0000000000..868e155014 --- /dev/null +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json @@ -0,0 +1,131 @@ +{ + "rule-11-6-a": { + "Section": 11, + "Rule": 6, + "Test": "a", + "test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are correctly modeled.", + "expected_rule_outcome": "pass", + "standard": { + "rule_id": "11-6", + "ruleset_reference": "Table G3.1 #11, baseline column, i", + "rule_description": "Piping losses shall not be modeled.", + "applicable_rmr": "Baseline Model", + "rule_assertion": "=", + "comparison_value": "Expected Value", + "mandatory_rule": "No", + "schema_version": "0.0.34" + }, + "rmd_transformations": { + "baseline": { + "id": "ASHRAE229 1", + "calendar": { + "is_leap_year": false + }, + "data_timestamp": "2024-02-12T12:00Z", + "ruleset_model_descriptions": [ + { + "id": "RMD 1", + "buildings": [ + { + "id": "Building 1", + "building_segments": [ + { + "id": "Building Segment 1", + "zones": [ + { + "id": "Thermal Zone 1", + "floor_name": "Floor1", + "spaces": [ + { + "id": "Space 1", + "floor_area": 929.0303999999999 + } + ] + } + ] + } + ] + } + ], + "service_water_heating_distribution_systems": [ + { + "id": "SHW 1", + "service_water_piping": [ + { + "id": "SHW Piping 1", + "are_thermal_losses_modeled": true + } + ] + } + ], + "type": "BASELINE_0" + } + ] + } + } + }, + "rule-11-6-b": { + "Section": 11, + "Rule": 6, + "Test": "b", + "test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are not modeled.", + "expected_rule_outcome": "fail", + "standard": { + "rule_id": "11-6", + "ruleset_reference": "Table G3.1 #11, baseline column, i", + "rule_description": "Piping losses shall not be modeled.", + "applicable_rmr": "Baseline Model", + "rule_assertion": "=", + "comparison_value": "Expected Value", + "mandatory_rule": "No", + "schema_version": "0.0.34" + }, + "rmd_transformations": { + "baseline": { + "id": "ASHRAE229 1", + "calendar": { + "is_leap_year": false + }, + "data_timestamp": "2024-02-12T12:00Z", + "ruleset_model_descriptions": [ + { + "id": "RMD 1", + "buildings": [ + { + "id": "Building 1", + "building_segments": [ + { + "id": "Building Segment 1", + "zones": [ + { + "id": "Thermal Zone 1", + "floor_name": "Floor1", + "spaces": [ + { + "id": "Space 1" + } + ] + } + ] + } + ] + } + ], + "service_water_heating_distribution_systems": [ + { + "id": "SHW 1", + "service_water_piping": [ + { + "id": "SHW Piping 1", + "are_thermal_losses_modeled": false + } + ] + } + ], + "type": "BASELINE_0" + } + ] + } + } + } +} \ No newline at end of file From 05909eaa3bb4e3635a58c6579fd0c2ee2a61aff2 Mon Sep 17 00:00:00 2001 From: Juan Gonzalez Date: Thu, 12 Sep 2024 14:58:43 -0400 Subject: [PATCH 3/7] Update ASHRAE229.schema.json Indentation fix --- rct229/schema/ASHRAE229.schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rct229/schema/ASHRAE229.schema.json b/rct229/schema/ASHRAE229.schema.json index 2a9afb42dc..1a0e4ce12d 100644 --- a/rct229/schema/ASHRAE229.schema.json +++ b/rct229/schema/ASHRAE229.schema.json @@ -4226,7 +4226,7 @@ "description": "Indicates if service water heating piping is a loop and recirculates", "type": "boolean" }, - "are_thermal_losses_modeled": { + "are_thermal_losses_modeled": { "description": "Indicates if thermal losses from the service water heating piping are modeled", "type": "boolean" }, @@ -5084,4 +5084,4 @@ }, "version": "0.0.36", "$ref": "ASHRAE229.schema.json#/definitions/RulesetProjectDescription" -} \ No newline at end of file +} From 3cf0ef49936f36d63a17037ea9ec9c91ae28e361 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Thu, 12 Sep 2024 15:13:29 -0400 Subject: [PATCH 4/7] Added service weater heating uses to enumerations and made adjustment for indentation --- .../scripts/resources/json_pointer_enumerations.json | 1 + rct229/schema/ASHRAE229.schema.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json b/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json index 6aa3f61659..3b1bd72652 100644 --- a/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json +++ b/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json @@ -26,6 +26,7 @@ "sensible_cool_capacity": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/cooling_system/sensible_cool_capacity", "service_water_heating_distribution_systems": "ruleset_model_descriptions[0]/service_water_heating_distribution_systems", "service_water_piping":"ruleset_model_descriptions[0]/service_water_heating_distribution_systems[0]/service_water_piping", + "service_water_uses":"ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces[0]/service_water_heating_uses", "spaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces", "subsurfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces[0]/subsurfaces", "surfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces", diff --git a/rct229/schema/ASHRAE229.schema.json b/rct229/schema/ASHRAE229.schema.json index 2a9afb42dc..873d601c57 100644 --- a/rct229/schema/ASHRAE229.schema.json +++ b/rct229/schema/ASHRAE229.schema.json @@ -4226,7 +4226,7 @@ "description": "Indicates if service water heating piping is a loop and recirculates", "type": "boolean" }, - "are_thermal_losses_modeled": { + "are_thermal_losses_modeled": { "description": "Indicates if thermal losses from the service water heating piping are modeled", "type": "boolean" }, From 35fc2ef2ce9bca39ee59c3d39cdc2ac0879124bb Mon Sep 17 00:00:00 2001 From: gonz102 Date: Thu, 12 Sep 2024 15:20:00 -0400 Subject: [PATCH 5/7] minor typo correction. --- .../scripts/resources/json_pointer_enumerations.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json b/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json index 3b1bd72652..5fd892ac51 100644 --- a/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json +++ b/rct229/ruletest_engine/ruletest_jsons/scripts/resources/json_pointer_enumerations.json @@ -26,7 +26,7 @@ "sensible_cool_capacity": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/heating_ventilating_air_conditioning_systems[0]/cooling_system/sensible_cool_capacity", "service_water_heating_distribution_systems": "ruleset_model_descriptions[0]/service_water_heating_distribution_systems", "service_water_piping":"ruleset_model_descriptions[0]/service_water_heating_distribution_systems[0]/service_water_piping", - "service_water_uses":"ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces[0]/service_water_heating_uses", + "service_water_heating_uses":"ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces[0]/service_water_heating_uses", "spaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/spaces", "subsurfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces[0]/subsurfaces", "surfaces": "ruleset_model_descriptions[0]/buildings[0]/building_segments[0]/zones[0]/surfaces", From d0132a82128c7033e2afac8df6fa8f42ea1c3456 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Thu, 12 Sep 2024 15:24:37 -0400 Subject: [PATCH 6/7] Addressed issue where SHW distributions were not referenced by any space for 11-6 rule test --- .../ashrae9012019/section11/rule_11_6.json | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json index 868e155014..4e1e744db3 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json @@ -38,7 +38,12 @@ "spaces": [ { "id": "Space 1", - "floor_area": 929.0303999999999 + "service_water_heating_uses": [ + { + "id": "SHW 1", + "served_by_distribution_system": "SHW Distribution 1" + } + ] } ] } @@ -49,7 +54,7 @@ ], "service_water_heating_distribution_systems": [ { - "id": "SHW 1", + "id": "SHW Distribution 1", "service_water_piping": [ { "id": "SHW Piping 1", @@ -102,7 +107,13 @@ "floor_name": "Floor1", "spaces": [ { - "id": "Space 1" + "id": "Space 1", + "service_water_heating_uses": [ + { + "id": "SHW 1", + "served_by_distribution_system": "SHW Distribution 1" + } + ] } ] } @@ -113,7 +124,7 @@ ], "service_water_heating_distribution_systems": [ { - "id": "SHW 1", + "id": "SHW Distribution 1", "service_water_piping": [ { "id": "SHW Piping 1", From c29b727e81e5b33c6296524941d6bf60a3a03301 Mon Sep 17 00:00:00 2001 From: gonz102 Date: Wed, 18 Sep 2024 15:33:16 -0400 Subject: [PATCH 7/7] Flipped pass and fail cases for 11-6 ruletest --- .../ashrae9012019/section11/rule_11_6.json | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json index 4e1e744db3..a6faa0cab7 100644 --- a/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json +++ b/rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section11/rule_11_6.json @@ -3,7 +3,7 @@ "Section": 11, "Rule": 6, "Test": "a", - "test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are correctly modeled.", + "test_description": "A one story, single zone building has service hot water piping. The service hot water piping losses are correctly not modeled.", "expected_rule_outcome": "pass", "standard": { "rule_id": "11-6", @@ -12,7 +12,7 @@ "applicable_rmr": "Baseline Model", "rule_assertion": "=", "comparison_value": "Expected Value", - "mandatory_rule": "No", + "mandatory_rule": "Yes", "schema_version": "0.0.34" }, "rmd_transformations": { @@ -58,7 +58,7 @@ "service_water_piping": [ { "id": "SHW Piping 1", - "are_thermal_losses_modeled": true + "are_thermal_losses_modeled": false } ] } @@ -73,7 +73,7 @@ "Section": 11, "Rule": 6, "Test": "b", - "test_description": "A one story building, single zone building has service hot water piping. The service hot water piping losses are not modeled.", + "test_description": "A one story, single zone building has service hot water piping. The service hot water piping losses are modeled.", "expected_rule_outcome": "fail", "standard": { "rule_id": "11-6", @@ -82,7 +82,7 @@ "applicable_rmr": "Baseline Model", "rule_assertion": "=", "comparison_value": "Expected Value", - "mandatory_rule": "No", + "mandatory_rule": "Yes", "schema_version": "0.0.34" }, "rmd_transformations": { @@ -108,6 +108,7 @@ "spaces": [ { "id": "Space 1", + "service_water_heating_space_type": "OFFICE", "service_water_heating_uses": [ { "id": "SHW 1", @@ -128,7 +129,7 @@ "service_water_piping": [ { "id": "SHW Piping 1", - "are_thermal_losses_modeled": false + "are_thermal_losses_modeled": true } ] }