Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.py is full of + for string concatenation rather than os.path.join() #139

Open
trevorhardy opened this issue Mar 1, 2024 · 1 comment
Open

data.py is full of + for string concatenation rather than os.path.join() #139

trevorhardy opened this issue Mar 1, 2024 · 1 comment
Assignees
@trevorhardy
Labels
bug
Milestone
FY24-04

Comments

@trevorhardy
Copy link
Collaborator

All kinds of pathing problems on Windows are created by using + instead of os.path.join(). Many of the paths defined in data.py that are intended to be user-accessible are unusable as they contain mixed slashes (/, \).
@trevorhardy trevorhardy added the bug label Mar 1, 2024
@trevorhardy trevorhardy self-assigned this Mar 4, 2024
@trevorhardy trevorhardy added this to the FY24-04 milestone Mar 4, 2024
@trevorhardy
Copy link
Collaborator Author

Tested to be working on macOS and put into PR #142.

jk1066 added a commit that referenced this issue Oct 7, 2024
@jk1066
Replacing + with os.path.join() in data.py for Windows compatability.…
d824579 
… Issue #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorhardy trevorhardy

Labels
bug
Projects
None yet
Milestone
FY24-04
Development

No branches or pull requests
1 participant
@trevorhardy