URL encoding for use in SPO REST

[badmandragon]

We use the AddAsync function in adding files to SharePoint.

pnpcore/src/sdk/PnP.Core/Model/SharePoint/Core/Internal/FileCollection.cs

Line 24 in 3eef092

public async Task<IFile> AddAsync(string name, Stream content, bool overwrite = false)

What we noticed were, for content length <= 10 MB, this uses decodedUrl='{encodedServerFileName}' in the FileUpload method, however, when files are > 10MB, this uses url='{newFile.Name}' in the ChunkedFileUpload method.

FileUpload

pnpcore/src/sdk/PnP.Core/Model/SharePoint/Core/Internal/FileCollection.cs

Lines 76 to 77 in 3eef092

	var encodedServerFileName = WebUtility.UrlEncode(newFile.Name.Replace("'", "''").Replace("%20", " ")).Replace("+", "%20");
	string fileCreateRequest = $"_api/web/getFolderById('{{Parent.Id}}')/files/addusingpath(decodedUrl='{encodedServerFileName}',overwrite={overwrite.ToString().ToLowerInvariant()})";

ChunkedFileUpload

pnpcore/src/sdk/PnP.Core/Model/SharePoint/Core/Internal/FileCollection.cs

Line 110 in 3eef092

string fileCreateRequest = $"_api/web/getFolderById('{{Parent.Id}}')/files/add(url='{newFile.Name}',overwrite={overwrite.ToString().ToLowerInvariant()})";

The behaviour here is different and with ' being in file names, depending on file size will depends if we receive errors or not.

I was wondering if this is a feature or does the same encoding need to be applied to the ChunkedFileUpload method?

[jansenbe]

@badmandragon : thanks for making us aware of this, the chunked upload should also use addusingpath. I've updated this and this change will be part of the next nightly build.

[badmandragon]

Thanks @jansenbe, Do you have a timeline of when this will be released and when it can be used for a production environment?

[jansenbe]

@badmandragon : we don't have a timeline yet for the next major release, but feel free to use the nightly in the mean time. The key difference is that it's binaries are not signed.