Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the Target variants for less cloning and less duplicated code. #408

Closed
afck opened this issue Jun 2, 2019 · 0 comments · Fixed by #410
Closed

Change the Target variants for less cloning and less duplicated code. #408

afck opened this issue Jun 2, 2019 · 0 comments · Fixed by #410
Assignees
@afck

Comments

@afck
Copy link
Collaborator

afck commented Jun 2, 2019

With #405, Target::All is somewhat redundant, since it is identical to Target::AllExcept(BTreeSet::new()).

Possibly we should also replace the Node variant with a Nodes(BTreeSet<N>), to avoid unnecessarily cloning messages.

And we should double-check whether BTreeSet is the right choice; often Vec is faster.
@afck afck mentioned this issue Jun 2, 2019
Merged
7 tasks
@afck afck self-assigned this Jun 18, 2019
@afck afck mentioned this issue Jun 18, 2019
Merged
@afck afck closed this as completed in #410 Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afck afck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the Target variants. poanetwork/hbbft
1 participant
@afck