From 46e1a3752b9593bbe1f486a1f935dfed0bfaec7d Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 21 Dec 2018 17:28:13 +0300 Subject: [PATCH 01/79] Multiple ledger accounts --- package-lock.json | 5 ++--- package.json | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 0481b742d422..19b5f76f397e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10525,9 +10525,8 @@ } }, "eth-ledger-bridge-keyring": { - "version": "0.1.1", - "resolved": "https://registry.npmjs.org/eth-ledger-bridge-keyring/-/eth-ledger-bridge-keyring-0.1.1.tgz", - "integrity": "sha512-EhClGSy5ixcd55yHGXoA3C7I8iFFi6kgSqvKOSj+5URtg5PYpHP8kv+KemFPOT1Px6se/IFHI9OIelUS8kN3lw==", + "version": "github:vbaranov/eth-ledger-bridge-keyring#949e3786ed9c41f47f5e1ee676eef427d58bb0fc", + "from": "github:vbaranov/eth-ledger-bridge-keyring#master", "requires": { "eth-sig-util": "^1.4.2", "ethereumjs-tx": "^1.3.4", diff --git a/package.json b/package.json index f3e2d1bc4322..d33eda1c1a81 100644 --- a/package.json +++ b/package.json @@ -116,7 +116,7 @@ "eth-json-rpc-filters": "github:poanetwork/eth-json-rpc-filters#3.0.2", "eth-json-rpc-infura": "^3.0.0", "eth-keychain-controller": "github:vbaranov/KeyringController#simple-address", - "eth-ledger-bridge-keyring": "^0.1.1", + "eth-ledger-bridge-keyring": "github:vbaranov/eth-ledger-bridge-keyring#master", "eth-method-registry": "^1.0.0", "eth-net-props": "^1.0.10", "eth-phishing-detect": "^1.1.4", From 5bc0b844dceb9bbe7a4c17ced84e199acdfc89a0 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 21 Dec 2018 18:40:16 +0300 Subject: [PATCH 02/79] check, if HD account was unlocked before on Ledger --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 19b5f76f397e..d2e195992d6c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10525,7 +10525,7 @@ } }, "eth-ledger-bridge-keyring": { - "version": "github:vbaranov/eth-ledger-bridge-keyring#949e3786ed9c41f47f5e1ee676eef427d58bb0fc", + "version": "github:vbaranov/eth-ledger-bridge-keyring#097807e7971ad0d2792be89ce93428f688d0a178", "from": "github:vbaranov/eth-ledger-bridge-keyring#master", "requires": { "eth-sig-util": "^1.4.2", From cd69b9b9609ab20bcfb9a117edda764de8f1f99b Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 21 Dec 2018 18:51:18 +0300 Subject: [PATCH 03/79] bind to another branch --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index d2e195992d6c..0f006cfcdbae 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10526,7 +10526,7 @@ }, "eth-ledger-bridge-keyring": { "version": "github:vbaranov/eth-ledger-bridge-keyring#097807e7971ad0d2792be89ce93428f688d0a178", - "from": "github:vbaranov/eth-ledger-bridge-keyring#master", + "from": "github:vbaranov/eth-ledger-bridge-keyring#multiple-accounts", "requires": { "eth-sig-util": "^1.4.2", "ethereumjs-tx": "^1.3.4", diff --git a/package.json b/package.json index d33eda1c1a81..d03936e2ff6a 100644 --- a/package.json +++ b/package.json @@ -116,7 +116,7 @@ "eth-json-rpc-filters": "github:poanetwork/eth-json-rpc-filters#3.0.2", "eth-json-rpc-infura": "^3.0.0", "eth-keychain-controller": "github:vbaranov/KeyringController#simple-address", - "eth-ledger-bridge-keyring": "github:vbaranov/eth-ledger-bridge-keyring#master", + "eth-ledger-bridge-keyring": "github:vbaranov/eth-ledger-bridge-keyring#multiple-accounts", "eth-method-registry": "^1.0.0", "eth-net-props": "^1.0.10", "eth-phishing-detect": "^1.1.4", From 592fc7254e5f0fc252815d24b10406b1ea4144e1 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 21 Dec 2018 20:04:07 +0300 Subject: [PATCH 04/79] remove console.log --- .../connect-hardware/account-list.js | 46 +++++++++++++---- .../app/components/connect-hardware/index.js | 50 ++++++++++++++++--- .../app/components/connect-hardware/util.js | 8 +++ old-ui/app/components/send/send-contract.js | 1 - 4 files changed, 86 insertions(+), 19 deletions(-) create mode 100644 old-ui/app/components/connect-hardware/util.js diff --git a/old-ui/app/components/connect-hardware/account-list.js b/old-ui/app/components/connect-hardware/account-list.js index 10cfbf038412..370ca88f022d 100644 --- a/old-ui/app/components/connect-hardware/account-list.js +++ b/old-ui/app/components/connect-hardware/account-list.js @@ -4,6 +4,7 @@ import ethNetProps from 'eth-net-props' import { default as Select } from 'react-select' import Button from '../../../../ui/app/components/button' import { capitalizeFirstLetter } from '../../../../app/scripts/lib/util' +import { isLedger } from './util' class AccountList extends Component { constructor (props, context) { @@ -67,26 +68,50 @@ class AccountList extends Component {

{`Unlock ${capitalizeFirstLetter(device)}`}

{device.toLowerCase() === 'ledger' ? this.renderHdPathSelector() : null} -

Select the account to view in Nifty Wallet

+

Select the accounts to view in Nifty Wallet

) } + renderInput = (a, i) => { + const { device } = this.props + if (isLedger(device)) { + return ( + { + console.log('onChange event') + this.props.onAccountChange(e.target.value) +} + } + checked={this.props.selectedAccounts.includes(a.index.toString())} + /> + ) + } else { + return ( + this.props.onAccountChange(e.target.value)} + checked={this.props.selectedAccount === a.index.toString()} + /> + ) + } + } + renderAccounts = () => { const rows = [] this.props.accounts.forEach((a, i) => { rows.push(
- this.props.onAccountChange(e.target.value)} - checked={this.props.selectedAccount === a.index.toString()} - /> + {this.renderInput(a, i)}