New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove benign reports from AuRa #110

Open

vkomenda opened this issue Mar 20, 2019 · 1 comment

vkomenda commented Mar 20, 2019

AuRa still calls report_benign despite the fact that that function is absent in posdao-contracts.

We should remove those calls.
The validator set contract tests that imply calls to report_benign should be fixed.

The text was updated successfully, but these errors were encountered:

varasev commented Mar 26, 2019 •

edited

Loading

We should remove those calls.

Please keep report benign logging: we should see the Reported benign validator misbehaviour 0x... lines in the logs even if the reportBenign function is not called by a node. An example of the logs I meant: https://wiki.parity.io/Validator-Set-Tutorial-4.html#1-let-node0-be-down

afck mentioned this issue

Queue malice reports and fix the unit tests. #129

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment