Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide release for version 0.12.4 of wkhtmltopdf binaries #8

Open
ghost opened this issue Aug 23, 2017 · 3 comments
Open

Provide release for version 0.12.4 of wkhtmltopdf binaries #8

ghost opened this issue Aug 23, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2017

Hello there,

Version 0.12.4 of wkhtmltopdf contains a fix that is likely to resolve some elusive JsReport render request failures that I've been observing in a production application. Would you be able to provide an updated release containing these binaries?

If needed, I'm happy to do up a pull request too (I assume it's simply a matter of creating the zipped up binaries for each OS with just the 64-bit version of the corresponding wkhtmltopdf binary).

@pofider
Copy link
Owner

pofider commented Aug 23, 2017

Thank you for information. PR would be great.

Did you observe any "back compatibility" changes with previous version?
Like that the output pdf would look visually different in sizes?
Just checking if we can release this in minor version increase.

@ghost
Copy link
Author

ghost commented Aug 27, 2017

Apologies about the delayed reply.

Did you observe any "back compatibility" changes with previous version?

It appears I didn't do enough digging before making this request for version 0.12.4 of wkhtmltopdf. The Mac distribution appears to have a regression related to font scaling. I have JsReport running on a Ubuntu box, which is why I overlooked the latter issue. As such, feel free to close this off if you think it's better to wait for 0.12.5.

In the meanwhile, I've been trying to manually compile the wkhtmltopdf binary from source (because I can't find them being distributed) but with limited success. Do you happen to have any special instructions or tips to obtain statically-built binaries? (I assume somebody must've done this for the binaries that are distributed with this package).

@pofider
Copy link
Owner

pofider commented Aug 27, 2017

I see. Seems the wkhtmtopdf runs into the same issue as phantomjs. The different versions are starting to produce different pdf element sizes. It will be anyway the best to let the developers decide explicitly which version of the binary should be used. I will look into it.

I've never tried to compile wkhtmltopdf from the sources. The binaries attached in this package are simply downloaded. Unfortunately I've no hints for you here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant