Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of types and factory methods can conflict #1

Open
drewnoakes opened this issue Aug 30, 2016 · 0 comments
Open

Visibility of types and factory methods can conflict #1

drewnoakes opened this issue Aug 30, 2016 · 0 comments

Comments

@drewnoakes
Copy link
Member

drewnoakes commented Aug 30, 2016

Servant supports registering internal and private types, but the factory methods must be public. This disallows a use case where a public type depends upon an internal one and is constructed via a factory, as if the factory must be public, it cannot have a parameter of internal type.

Allow non-private constructors/factory methods (meaning internal as well as the current public), allowing types to remain internal. Add a unit test for this with types that illustrate the problem, which would fail to run currently. Update API documentation and README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant