Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC] Import the rlang package #942

Closed
eitsupi opened this issue Mar 19, 2024 · 3 comments
Closed

[DISC] Import the rlang package #942

eitsupi opened this issue Mar 19, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented Mar 19, 2024

Related to #939 (and potentially #367)

With limited development resources, I don't want to reinvent the wheel any further with what rlang has to offer.
I think there used to be value in not having dependencies to install binary packages on GitHub releases, but I don't see much value in not having dependencies now that installing from the R-universe works so well.

rlang is very widely used and rlang itself is a very small dependency since it does not depend on any other package.

Pros

  • Features such as trailing commas and dot checks will be available.

Cons

  • This will be the first external required dependency.

@etiennebacher @sorhawell @vincentarelbundock @grantmcdermott @Sicheng-Pan Thoughts?

@etiennebacher
Copy link
Collaborator

I think it is overkill to import rlang just for a couple of functions, I never feel I'm missing this kind of functionalities when developing polars. My point of view might change if we were missing many utils but for now I simply don't see the need

@eitsupi
Copy link
Collaborator Author

eitsupi commented Apr 14, 2024

Recently to enforce named arguments with ... is increasingly used, and given the frequency with which Polars change argument names, it would be worthwhile to use the rlang::check_dots_empty() function to check arguments to reduce implicit failures for the user.

I am not sure how much emphasis on no dependencies is worth.

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 27, 2024

Closing in favor of #1152

@eitsupi eitsupi closed this as completed Jun 27, 2024
@eitsupi eitsupi closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants