Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revm support / evm abstraction #1495

Open
MOZGIII opened this issue Aug 20, 2024 · 0 comments
Open

revm support / evm abstraction #1495

MOZGIII opened this issue Aug 20, 2024 · 0 comments
Labels

Comments

@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 20, 2024

Question

Frontier depends on evm crate heavily:

$ cargo tree -p evm --invert --depth 1
evm v0.41.1
├── fc-rpc v2.0.0-dev (.../frontier/client/rpc)
├── fp-evm v3.0.0-dev (.../frontier/primitives/evm)
│   [dev-dependencies]
├── pallet-ethereum v4.0.0-dev (.../frontier/frame/ethereum)
├── pallet-evm v6.0.0-dev (.../frontier/frame/evm)
├── pallet-evm-test-vector-support v1.0.0-dev (.../frontier/frame/evm/test-vector-support)
│   [dev-dependencies]
├── precompile-utils v0.1.0 (.../frontier/precompiles)
│   [dev-dependencies]
└── precompile-utils-tests-external v0.1.0 (.../frontier/precompiles/tests-external)

The only dependency that makes sense is at pallet-evm, the rest look like leaked abstraction.
pallet-evm supports abstracting around the runner, but it doesn't really work the way the code is structured currently.

Why don't we make Frontier abstract around the evm implementation? That would be nice for supporting alternative EVM implementations.

@MOZGIII MOZGIII changed the title revm support revm support / evm abstraction Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant