Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BountyType with new PalletBountiesBounty #11192

Closed
TarikGul opened this issue Jan 9, 2025 · 2 comments · Fixed by #11204
Closed

Fix BountyType with new PalletBountiesBounty #11192

TarikGul opened this issue Jan 9, 2025 · 2 comments · Fixed by #11204
Assignees
Labels
P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.

Comments

@TarikGul
Copy link
Member

TarikGul commented Jan 9, 2025

The polkadot-js api update with the substrate types in the most recent release 15.2.1 has introduced a break in the TS compiler.

The old type: Bounty

The new type: PalletBountiesBounty

The new type has already existed and is the return value for bounty.bounties for a while. But seems as if there is some underlying sub type that has changed and is causing issues. The PR which introduces this change is #11191.

For now I have added a bunch of type casts to ensure that the ts compiler doesn't break, this should be addressed in a follow up PR.

@TarikGul TarikGul added the P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow. label Jan 10, 2025
@TarikGul
Copy link
Member Author

It is important to note, when we update for the new type we should:

  1. find the underlying differences between the types.

  2. ensure that we have forward and backwards compatibility so we don't break any chains still using the older bounty pallet versions.

@ap211unitech ap211unitech linked a pull request Jan 14, 2025 that will close this issue
3 tasks
@ap211unitech ap211unitech self-assigned this Jan 14, 2025
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.
Development

Successfully merging a pull request may close this issue.

3 participants