Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better status codes for gateway #24

Closed
Tracked by #22
nerfZael opened this issue Mar 4, 2022 · 1 comment
Closed
Tracked by #22

Better status codes for gateway #24

nerfZael opened this issue Mar 4, 2022 · 1 comment
Assignees
@nerfZael
Labels
persistence-node
Milestone
alpha

Comments

@nerfZael
Copy link
Collaborator

nerfZael commented Mar 4, 2022 •
edited
Loading

Applies to endpoints /api/v0/cat, /api/v0/resolve, /ipfs
Endpoints which are modeled after the IPFS gateway (/api/v0/...) should implement the IPFS HTTP API specs
@nerfZael nerfZael added this to the Persistence node: 0.2.0 milestone Mar 22, 2022
@i-vukman i-vukman self-assigned this Mar 27, 2022
@nerfZael nerfZael mentioned this issue Mar 30, 2022
Closed
17 tasks
@nerfZael nerfZael changed the title Persistence Node: Return 404 instead of 500 when a file is not found Return 404 instead of 500 when a file is not found Mar 30, 2022
@nerfZael nerfZael moved this to Ready for dev in Protocol Apr 2, 2022
@nerfZael nerfZael moved this from Ready for dev to Blocked in Protocol Apr 2, 2022
@nerfZael nerfZael mentioned this issue Apr 3, 2022
Open
@nerfZael nerfZael moved this from Blocked to In progress in Protocol Apr 4, 2022
@i-vukman i-vukman linked a pull request Apr 9, 2022 that will close this issue
WIP: 404 instead of 500 when file not found #79
Closed
@nerfZael nerfZael changed the title Return 404 instead of 500 when a file is not found Better status codes for gateway Apr 12, 2022
@nerfZael nerfZael moved this from In progress to Ready for dev in Protocol May 3, 2022
@nerfZael nerfZael assigned nerfZael and unassigned i-vukman Jun 3, 2022
@nerfZael nerfZael moved this from Ready for dev to In progress in Protocol Jun 3, 2022
@nerfZael
Copy link
Collaborator Author

nerfZael commented Jun 7, 2022

This was mostly related to errors that happen on the gatway. It is already implemented for error 500, every error thrown gets wrapped into a JSON object: { Type: "error", Message: string }

@nerfZael nerfZael closed this as completed Jun 7, 2022
Repository owner moved this from In progress to Done in Protocol Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nerfZael nerfZael

Labels
persistence-node
Projects
Protocol
Status: Done
Milestone
alpha
Development

Successfully merging a pull request may close this issue.

WIP: 404 instead of 500 when file not found polywrap/nodes
2 participants
@i-vukman @nerfZael