-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle output of new owltools version when computing closure #706
Comments
Is the priority of this still medium? how quick is it? |
I've just made the changes to support the new output style. In case the results will be slightly different from the current version, I won't check the changes in today. I'll test it in the nightly load over the weekend. |
Relation term names are now IDs. Refs #706
I've checked in the changes to support the new OWLTools. Tomorrow I'll see if I can spot any major ontology problems. |
There's good news and, er, other news. The good news is that it mostly looks fine. The other news is that I spotted an ontology closure problem that been around for a while. In the main site now, sister chromatid segregation (GO:0000819) has 184 gene annotated according to this page: https://www.pombase.org/term/GO:0000819 The difference is that "meiosis I spindle assembly checkpoint (GO:1905318)" annotations appear on yesterday's "sister chromatid segregation (GO:0000819)" page, but not after updating OWLTools. Here's the GO terms and relations that connect those terms. There might be other paths, I didn't check. Maybe the problem is caused by the "regulates" relation?
I don't think the OWLTools update is causing this problem. I checked the Chado databases going back a few weeks and sometimes "meiosis I spindle assembly checkpoint (GO:1905318)" is a descendent of "sister chromatid segregation (GO:0000819)" page and sometimes not. This seems similar to geneontology/go-ontology#16687 |
I can only find this ticket I know I opened some tickets on the GO tracker about this. I described it as "annotation flip-flopping". I can't find any of the tickets relating to this issue. The only other thing I remember is that the examples were from "cytoskeleton organization" and "conjugation with cellular fusion" |
In our earlier encounters with this problem, we pinned it on owltools (tho apparently some part of it that's unaffected by the update). The most informative tickets aren't the ones on the GO ontology tracker; they're #678 on this tracker and the linked ticket on the owltools tracker. |
Thanks. |
I've commented in the owltools issue about this: owlcollab/owltools#256 |
I'll close this one since there's an owltools issue for the problem. |
In the latest version of owltools, "part_of" has changed to "BFO:0000050" in the relation column. Other relations have changed too. eg. "negatively_regulates" in now "RO:0002212".
This needs fixing in the loader code before we can upgrade. Upgrading isn't urgent though.
Refs geneontology/go-ontology#16776
The text was updated successfully, but these errors were encountered: