-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full view extension presentation on phosphorylation phenotypes #2272
Comments
Yep, we can do that. If I change the configuration so that residue extensions can be grouped together I get this: https://desktop.kmr.nz/gene/SPBC11B10.09 We also have https://dev.pombase.org/gene/SPBC530.14c Is that OK? |
Not sure. @PCarme is it clear that the residue belongs to the preceding ID in the list? Also in the first figure, by grouping be residue, we lose cdc2-33(A177T aa) affecting cdc13, orc2, sld3 grouping ideally it would be then the same for each allele Is that possible? I think people will primarily want the same allele together, then the most compacted version of that information. |
It is clear to me at least, although it feels a bit awkward.
I agree, this would be a better solution overall |
Sorry, I realise that I got this wrong. The screenshot for cdc2 shows the residues grouped together but that was from when I had mis-configured my desktop site. Adding the configuration to group by "modified residue" doesn't work in this case because (I now realise) it's not possible to group by two different extension relations in the same annnotation. The code doesn't support that. It's tricky code so I can't say how long this will take to fix. I've having a look now. |
I think I've fixed that, more or less. There might still be some situations where the grouping doesn't happen, but I think most cases will be covered. The change will be on pombase.org in the morning. |
Fantastic. We will look it over and then we can also use the same configuration for other terms which have extensions and residues (if not already). That would be all children of |
So in the figure above I still see 3 rows for cdc2-33 affecting cdc18 |
Yep, there are still have cases that aren't collected together. It's tricky to get it working in all situations, but I'll have a look at that one tomorrow. |
It's there now. Let me know if you spot any problems. It's new code which makes bugs more likely. |
Amazing. That's brillaint! |
In these cases we could group
like
cdc2-33(A177T aa) affecting cdc18 modified residue T10A,T46A,T60AT104A,T134A
cdc2-33(A177T aa) affecting rap1 modified residue T378,S422,S513
etc
The text was updated successfully, but these errors were encountered: