Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

X-Reva-Secret header missing error is used for wrong situatoin. #219

Open
shokri-navid opened this issue Aug 28, 2022 · 1 comment
Open

Comments

@shokri-navid
Copy link

I found that the X-Reva-Secret header missing error is raised because of two situations:

1- when the Reva version is under 1.19.0: in these versions, the NextCould manager of Reva does not add the X-Reva-Secret header to the HTTP request.

2- when X-Reva-Secret is sent from Reva side to the Nextcloud with the wrong value.

in the first case, it seems it is better to provide a hint about the Reva version.
in the second case, it seems it is better that we return another error message that indicates the wrong value.

@MahdiBaghbani
Copy link
Member

@michielbdejong @navid-shokri is it fixed or we have to fix it? is it even necessary anymore?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants