-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report 基地防空戦 compositions? #11
Comments
Land base raid happens randomly and does not let any ship drop, it is better to record in another collection On |
Anyway the But what could air raid data collection serve for? |
Using the same data collection will result in double drop reports in a single battle on certain cells and the drop rate on these cells will never be accurate |
@KagamiChan would it be ok for another viewer to implement this? I.e., to report |
I still prefer creating a separate data collection for this, anyway staff at kcwiki should be informed and involved @Gizeta |
I don't think it's a good idea to save land base air raid compositions in the record = data.cellId < 0 ? new NewTableForLandBaseAirRaid(data) : new DropShipRecord(data)
record.save() But, I think it's tricky. Why not create some new API on |
Well, my argument was that there is already non-drop and composition-only data from corresponding (game) endpoints in If it must be a different table, then yeah, extra class/schema/endpoint here and in |
and I'll add the dumping once the data set is available P.S. Here's some instructions on how to locally test reporter and poi server: https://github.com/poooi/plugin-report/wiki |
Looking at https://github.com/andanteyk/ElectronicObserver/blob/develop/ElectronicObserver/Other/Information/apilist.txt#L1517 there is more things in
|
That is,
api_destruction_battle
fromapi_req_map/next
. Something like this afterplugin-report/index.es
Line 182 in 1458cf1
Also, should it be
instead of
plugin-report/index.es
Line 170 in 1458cf1
The text was updated successfully, but these errors were encountered: