Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual refinement for nested rounded corners #767

Open
git-f0x opened this issue Dec 30, 2024 · 0 comments
Open

Visual refinement for nested rounded corners #767

git-f0x opened this issue Dec 30, 2024 · 0 comments

Comments

@git-f0x
Copy link
Contributor

git-f0x commented Dec 30, 2024

The nested rounded corners that appear in some places like the window and window sidebar corners currently use the same radius variable. Since there's a padding of 8 between them, this leads to the outer radius (window corner) visually sticking out:
screenshot-2024-12-30-16-04-52

It could be improved by increasing the outer radius by 1/2 of padding (adding the entire padding is mathematically correct for achieving concentric corners, but doesn't look good), which visually aligns the corners:
screenshot-2024-12-30-16-02-14

This would be implemented by having the outer radius use the following rule:
window_corner_radius = radius_s().map(|radius| if radius < 4.0 { radius } else { radius + 4.0 })
This also ensures that the Square style remains square, and is unaffected by this change.

This issue is created to gather feedback on the change.
CC @pop-os/ux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant