Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tiled window corner radius separately from various UI elements #806

Open
boomshroom opened this issue Feb 17, 2025 · 3 comments
Open

Comments

@boomshroom
Copy link

I like to use use primarily stacked mode, but part of that is wanting no space between windows and the edge of the screen, which is why Gaps around tiled windows is set to 0. As it stands, there are very small, but annoying, gaps in the corners of libcosmic windows as well as the top corners of the stack header bar. While these could be desirable when using intentional gaps around windows, they're not so desirable in my use-case. As it stands, this could be resolved by setting radius_s to 0 for all 4 corners, but this has the undesired side-effect of making various unrelated elements within libcosmic apps square, whereas I'd prefer to keep said elements primarily rounded. A possible work-around is to open up a libcosmic app and make it full-screen within a stack causing the stack header bar to become square, though this has its own issues.

Also, even when rounded window edges are desired in tiling mode, I have trouble seeing a reason to make the top corners of a window rounded when in stacked mode. I would expect the corners to only apply to the bottom corners of the window and the top corners of the stack header bar.

@boomshroom boomshroom changed the title Set window corner radius separately from various UI elements Set tiled window corner radius separately from various UI elements Feb 17, 2025
@git-f0x
Copy link
Contributor

git-f0x commented Feb 19, 2025

The corners of libcosmic app windows should technically be square when tiling (similar to GTK apps), but there are bugs with the detection of window states currently (e.g. in the code, sharp_corners should be set to true when a window is tiled, but that doesn't happen).
GTK apps also get square corners when stacked, but ideally, only the top corners would be made square, but it probably needs support on the app side (GTK/libcosmic).

@boomshroom
Copy link
Author

I considered making it about sharp_corners, but then considered that some people who use tiling windows like gaps between them, and having rounded corners when tiled with gaps still makes sense. Enabling sharp_corners specifically when gaps are set to 0 could still work though.

I have been able to force sharp_corners by opening a libcosmic app within a window stack and then making it full screen, which then makes the stack header bar flush with the screen corners, but it's very awkward to actually use.

@Drakulix
Copy link
Member

I considered making it about sharp_corners, but then considered that some people who use tiling windows like gaps between them, and having rounded corners when tiled with gaps still makes sense.

No, that would be against the xdg-shell spec.

What should happen here, if people want round corners in tiled mode is the compositor clipping the window. Tiled windows themselves should never apply something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants