Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Should strip the build #107

Open
zoxpx opened this issue Feb 4, 2020 · 0 comments
Open

[bug] Should strip the build #107

zoxpx opened this issue Feb 4, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@zoxpx
Copy link

zoxpx commented Feb 4, 2020

Describe the bug
The Linux bits packaged in https://github.com/portworx/pxc/releases/tag/v0.23.0 are not stripped (I assume Mac and Windows bits are not either).

To strip the binaries, one should do the following:

  • run strip kubectl-pxc before packaging the final build, or
  • [better yet] compile bits via go -i -v -ldflags "-s -w" ...

Version
v0.23.0

To Reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Actual behavior
A clear and concise description of what you expected to happen.

Additional Information

@zoxpx zoxpx added the bug Something isn't working label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant