Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making (more) Impossible States Impossible #153

Open
nevrome opened this issue Jan 15, 2022 · 2 comments
Open

Making (more) Impossible States Impossible #153

nevrome opened this issue Jan 15, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request for the future

Comments

@nevrome
Copy link
Member

nevrome commented Jan 15, 2022

I watched this short and sweet talk by Richard Feldman and was reminded of some things one should refactor in the janno data type (some of these things are still in #152): The column families Date_*, Relation_* and Contamination_* all come with states that should not be representable. Right now validation functions ensure that the input read from .janno files is correct, but it would be more reliable and more elegant to solve this on a type level.

@nevrome nevrome self-assigned this Jan 15, 2022
@nevrome nevrome added the enhancement New feature or request label Jan 15, 2022
@stschiff
Copy link
Member

I've checked out the talk. Very nice. And indeed, that's a good idea.

@nevrome
Copy link
Member Author

nevrome commented Mar 13, 2022

As discussed in #163 another helpful type in this context might be NonEmpty, which defines lists that have at least one element. We could use this e.g. for Group_Names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request for the future
Projects
None yet
Development

No branches or pull requests

2 participants