You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently came across an issue where I accidentally committed a Janno-file that had Windows line endings (CRLF) (see poseidon-framework/community-archive#214). Checksums were computed based on these files and committed, and the package validated. We only caught this because git converted the line endings implicitly into LF, which in turn changed the file and invalidated the checksum.
Whether or not we divide to change git-attributes (see poseidon-framework/community-archive#215), we should build in a check within trident validate that checks for line endings in all text-files that are checksum-validated, including .ind, .fam, .snp, .bim, .vcf (in the future), .geno, .bib, .janno.
The text was updated successfully, but these errors were encountered:
In today's discussion we concluded that such a check is not necessary in trident, but instead only in the public archives. Maybe that's what we try for now. Requiring one specific line ending is a change we should first encode in the Poseidon schema.
We recently came across an issue where I accidentally committed a Janno-file that had Windows line endings (CRLF) (see poseidon-framework/community-archive#214). Checksums were computed based on these files and committed, and the package validated. We only caught this because git converted the line endings implicitly into LF, which in turn changed the file and invalidated the checksum.
Whether or not we divide to change git-attributes (see poseidon-framework/community-archive#215), we should build in a check within
trident validate
that checks for line endings in all text-files that are checksum-validated, including.ind
,.fam
,.snp
,.bim
,.vcf
(in the future),.geno
,.bib
,.janno
.The text was updated successfully, but these errors were encountered: