Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quarto to 1.6.42 hotfix #6455

Closed
wants to merge 1 commit into from
Closed

Conversation

petetronic
Copy link
Collaborator

@petetronic petetronic commented Feb 24, 2025

Quarto addressed a regression with code completions for .qmd files and backported the fix to in the 1.6.42 release.

Release Notes

New Features

  • Update Quarto to 1.6.42

Bug Fixes

QA Notes

A quick test is needed to confirm autocompletions are provided in a code block in a .qmd file

Quarto addressed a regression with code completions for .qmd files and backported
the fix to the 1.6 release.
Copy link

github-actions bot commented Feb 24, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@petetronic
Copy link
Collaborator Author

petetronic commented Feb 24, 2025

In a simple .qmd

---
title: "Bug 6444 Test"
format: html
---

```{r}
library(ggplot2)
df <- diamonds
df.
```

Getting completions for the df variable in the R code block works:

Screenshot 2025-02-24 at 5 29 27 PM

@petetronic
Copy link
Collaborator Author

petetronic commented Feb 24, 2025

Tested using a macOS temp build https://github.com/posit-dev/positron-builds/actions/runs/13505873706

@juliasilge
Copy link
Contributor

I just downloaded the installer from https://github.com/posit-dev/positron-builds/actions/runs/13505873706 but don't see the updated Quarto:

Screenshot_2025-02-24_at_4_13_38 PM

And I still don't see any completions in Python chunks in a .qmd file.

Let me try making a local release build.

@juliasilge
Copy link
Contributor

Doing a local release build, I see:

[17:00:47] Synchronizing quarto 1.6.42...
[17:00:48] [Fetch queue] start fetching https://github.com/quarto-dev/quarto-cli/releases/download/v1.6.42/quarto-1.6.42-macos.tar.gz (0 remaining)
[17:00:48] Start fetching https://github.com/quarto-dev/quarto-cli/releases/download/v1.6.42/quarto-1.6.42-macos.tar.gz
[17:00:53] Fetch completed: Status 200. Took 5027 ms

But then I still saw Quarto 1.6.40 when I opened the local release build of Positron and that's when I realized that I must have installed Quarto myself, and Positron prefers that one to our bundled Quarto.

After I did sudo rm -rf /Applications/quarto then I saw 1.6.42 in Positron. ✅

However, I still don't see any Python completions in a .qmd file:

Screenshot 2025-02-24 at 5 07 14 PM

I see completions for:

  • Python code in the console
  • R chunks in a .qmd

but still not the ones originally reported in #6444, similar to #6444 (comment) who says they installed Quarto 1.6.42.

Might I still be missing something, similar to how I had to uninstall my non-bundled Quarto installations?

@juliasilge
Copy link
Contributor

juliasilge commented Feb 25, 2025

I don't think this was ever a problem for R; I can get R completions fine in Positron with Quarto 1.6.40. Maybe entirely unrelated to rstudio/rstudio#15737?

Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fix applies to us; see my notes in #6444 (comment).

@petetronic petetronic closed this Feb 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
@petetronic
Copy link
Collaborator Author

Ok, we'll need to track down what happened around the time of the 1.96 upstream merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants