-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use posit cdn instead of github release asset for download url #6496
base: main
Are you sure you want to change the base?
Conversation
E2E Tests 🚀 |
case 'linux': | ||
suffix = '.deb'; | ||
break; | ||
case 'win32': | ||
suffix = '.exe'; | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this as it doesn't seem like we support linux/win32 anyways? See lower down in this function where we look for the executablePath
-- only mac is supported there.
const asset = release.assets.find((a: any) => a.name.endsWith(suffix)); | ||
if (!asset) { | ||
throw new Error(`No asset found with suffix ${suffix} for platform ${platform}`); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the error was occurring. We no longer publish assets for the binaries.
@petetronic Should we add something to the download URL to exclude this from download reporting? This is going to download a prerelease Positron on every PR. I'm not even sure why we need to download it for a PR test. |
Good point, if we can set a user agent, or if not, a query param, that marks it as Positron CI, that would be useful. |
We no longer publish the release binaries as assets, but the
downloadAndUnzipPositron()
function still assumes that we do.This PR updates the script to use the CDN url so we shouldn't see this error anymore when running Python extension MacOS tests:
QA Notes
Python Mac OS tests should now pass locally and in CI.