Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positron Assistant: Web compatibility #6506

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Feb 27, 2025

This change adds web compatibility and other improvements to Positron Assistant:

  • Disable the default vscode-api-tests default chat provider so that Positron Assistant can become the default chat provider in web dev mode (EDIT: It looks like this breaks the tests, so more work is needed here)
  • Store API keys in global storage, not secret storage, in web mode. This necessary because secret storage is not durable in web mode, so API keys are lost on reload. Using global storage isn't optimal, and should be revisited. See https://github.com/rstudio/vscode-server/issues/174.
  • Add Positron Assistant icon from Paul.
  • Use global storage, not settings JSON, to store the list of registered models. I don't think settings makes sense here because they are not really user editable.
  • Start adding quickpick to show registered models; this will eventually also let you delete one. We may upgrade this to a dedicated dialog later.

Some of this is still wet cement, mostly opening this to keep development lines open.

Copy link

github-actions bot commented Feb 27, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@jmcphers jmcphers requested a review from seeM February 27, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant