Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang : ioutil.ReadAll is deprecated from Go 1.16 #719

Closed
panapol-p opened this issue Aug 2, 2023 · 2 comments
Closed

golang : ioutil.ReadAll is deprecated from Go 1.16 #719

panapol-p opened this issue Aug 2, 2023 · 2 comments

Comments

@panapol-p
Copy link
Contributor

I saw deprecated function in go code generator

after Go 1.16 ioutil.ReadAll(...) is deprecated, we should use io.ReadAll(...) instead

Doc ref : https://pkg.go.dev/io/ioutil#ReadAll
Code : https://github.com/postmanlabs/postman-code-generators/blob/2411e41a03c59515fb78e363b0c93ba57f7d030b/codegens/golang/lib/index.js#L300C82-L300C96
@panapol-p panapol-p mentioned this issue Aug 6, 2023
Merged
@panapol-p
Copy link
Contributor Author

Hi, @theonly1me
could you pleaes help to review this change.

@panapol-p
Copy link
Contributor Author

merged #721 , #762

@theonly1me and @VShingala
Thank you for the review and the commit fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@panapol-p