Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventual CMake compatibility break #360

Open
ncorgan opened this issue Jun 14, 2022 · 1 comment
Open

Eventual CMake compatibility break #360

ncorgan opened this issue Jun 14, 2022 · 1 comment

Comments

@ncorgan
Copy link
Member

ncorgan commented Jun 14, 2022

From a recent Windows CI build (CMake 3.23.2):

-- #############################################
-- ## Begin configuration for Python support...
-- #############################################
-- Enabling optional Python bindings if possible...
CMake Deprecation Warning at swig/python/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.
  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

This line declares CMake 2.8 as the minimum, which I assume is from SoapySDR's beginnings. 2.8.0 is from 2009, and the last tag (2.8.12.2) is from 2014, so even though we list C++11 as the default, we're approaching a possible breaking point.

@zuckschwerdt
Copy link
Member

There is a short compatibility overview on https://gitlab.kitware.com/cmake/community/-/wikis/CMake-Versions-on-Linux-Distros
Requiring CMake 3 will bump the OS minimum to e.g. Debian 8 Jessie and Ubuntu 16.04 Xenial.
(I'd say it's reasonable to drop support for stock Wheezy / Trusty.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants