From 9e34a2e9607ff8e9a3bea72a8fd8444b85f5c724 Mon Sep 17 00:00:00 2001
From: bakaneko <notbakaneko@users.noreply.github.com>
Date: Mon, 31 Jul 2023 18:34:41 +0900
Subject: [PATCH] account for type of everyone option

---
 resources/js/beatmap-discussions/user-filter.tsx | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/resources/js/beatmap-discussions/user-filter.tsx b/resources/js/beatmap-discussions/user-filter.tsx
index c8197e6f4c8..ad2197b4d42 100644
--- a/resources/js/beatmap-discussions/user-filter.tsx
+++ b/resources/js/beatmap-discussions/user-filter.tsx
@@ -25,7 +25,7 @@ const noSelection = Object.freeze({
 
 interface Option {
   groups: UserJson['groups'];
-  id: UserJson['id'];
+  id: UserJson['id'] | null;
   text: UserJson['username'];
 }
 
@@ -91,9 +91,6 @@ export class UserFilter extends React.Component<Props> {
   }
 
   private readonly renderOption = ({ cssClasses, children, onClick, option }: OptionRenderProps<Option>) => {
-    // TODO: exclude null/undefined user from discussionsState
-    if (option.id < 0) return;
-
     const group = this.getGroup(option);
     const style = groupColour(group);
 
@@ -101,7 +98,7 @@ export class UserFilter extends React.Component<Props> {
     // means it doesn't work on non-beatmapset discussion paths
     if (urlOptions == null) return null;
 
-    urlOptions.user = option?.id;
+    urlOptions.user = option.id ?? undefined;
 
     return (
       <a