-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video/Storyboard leaks memory #31873
Comments
How much ram is 48.7% in the first place? I'm not sure if you're intentionally trying to omit details but you're doing a good job 😅😅
|
I have 32GB of RAM so 48.7% is 15.58GB. (I was not intentionally emitting details, but seems Windows just displays percentage in that "running out of RAM" page
1st beatmap (video only): https://osu.ppy.sh/beatmapsets/696697#osu/1475668
None of these helped
Should be both, as I used a video only and sb only map to test |
Can't reproduce on macOS at least. |
Can't reproduce on windows. Please start by updating your graphics drivers and unloading any overlays you may have loaded. It might be something external causing this. |
I managed to reproduce this issue on Windows 11, using a local release version of our latest branch, with a total available memory of about 16GB (32GB in total). I used Auto mod to play these maps and use shortcut key to quickly restart for multiple times.
After switching ruleset or exiting replay screen, the memory occupied won't be released and kept going up. And when I loaded about 75~80 maps, it used up all of the memory, causing the system to kill some processes. It seems like something wrong with resource loading and garbage collecting. |
@CloneWith More memory usage != memory leak. It may indicate one, but it is not necessarily one. Unless you can show which objects specifically are leaking from the dumps, your graphs don't prove anything or help resolve the issue at all, if there is one to resolve. |
Are you all using Direct3D11 (or "Automatic") in the in-game renderer settings? I'm aware of memory leaks in that renderer, and have made efforts in the past to resolve it but it may not be complete. If so, try using OpenGL. |
it seems not reproducible on Arch Linux, with version 2025.118.3-lazer. mine is stabilized at around 266MB memory after about 10 retries on the same map my renderer was |
There has to be something more here that is being omitted. I cannot reproduce using the same beatmaps over tens of loads using Direct X on windows. Maybe a skin element, maybe a setting, maybe a specific driver or overlay.
If you've gone as far as taking profiling showing a potential issue, would you be willing to share that via email? [email protected] |
By doing as the video I can get Gen2 to stack up to gigabytes Snapshot 1: Just launched, entered song select. After Snapshot 3 I did a force GC which helped, but there is still some more "unmanaged memory" than the two previous snapshots |
This is normal. There's nothing to learn here. Sure, storyboards need optimisation but this is tracked elsewhere and it's not a leak. They are being cleaned up as required. |
I've scanned my custom rulesets, and found one that may cause this problem. After removing that GC could work as normal again... So not a really big deal I think? 😣 Or it is a device-specific issue... |
I don't have proper knowledge so I want to ask. I don't see it being cleaned up (by osu itself), it just stacks up indefinitely over long sessions and potentially consumes tens of gigabytes, maybe run a GC when the session is too long and the player is idle? |
That's the .NET runtime's job. The only case where I can see it being our job is if the changes to GC mode that we do to get better GC behaviour during gameplay somehow do not revert correctly. |
Closing for now as working-as-intended. @PercyDan54 if you manage to get the 16 gb memory usage happening again, please perform a process memory dump from task manager and send a copy over. |
Type
Performance
Bug description
By repeatedly opening beatmaps with video/storyboard the memory keeps increasing
Happens on all renderers
Screenshots or videos
Found this on a 30 min session retrying a map with storyboard
![Image](https://private-user-images.githubusercontent.com/50285552/412711248-43bb708f-cb66-4bdd-86c4-cd3a3cc9b65d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzMwNTEsIm5iZiI6MTczOTkzMjc1MSwicGF0aCI6Ii81MDI4NTU1Mi80MTI3MTEyNDgtNDNiYjcwOGYtY2I2Ni00YmRkLTg2YzQtY2QzYTNjYzliNjVkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAyMzkxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVjZmE0NGU3ODI4NWE2YjYwMTcyZTIyNWU1MDQ3OWNiMzU1NTg2ZjI1MGVhNzUwN2RlZGRjZDI1MmRjNzI2ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.21bcOYlq8oylpE7ufpWZyxJBx_FWEQ8EX-WzKXDvOl0)
Repro:
https://youtu.be/SfJ8uF6uvbk
Version
2025.118.3
Logs
1739418922.runtime.log
The text was updated successfully, but these errors were encountered: