From 5a31c466a976b607e95de18a1f323ee82b30eeae Mon Sep 17 00:00:00 2001 From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com> Date: Wed, 12 Jun 2024 08:28:28 +1000 Subject: [PATCH 1/6] =?UTF-8?q?VS=20Code:=20left=20option=20=E2=86=92=20cm?= =?UTF-8?q?d=20+=20j=20(hide=20terminal)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../vs_code_left_option_hide_terminal.json | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 public/json/vs_code_left_option_hide_terminal.json diff --git a/public/json/vs_code_left_option_hide_terminal.json b/public/json/vs_code_left_option_hide_terminal.json new file mode 100644 index 000000000..86f5429f6 --- /dev/null +++ b/public/json/vs_code_left_option_hide_terminal.json @@ -0,0 +1,36 @@ +{ + "title": "left option → cmd + j (VS Code → hide terminal)", + "rules": [ + { + "description": "left option → cmd + j (VS Code → hide terminal)", + "manipulators": [ + { + "type": "basic", + "from": { + "key_code": "left_option", + "modifiers": { + "optional": ["any"] + } + }, + "to": [ + { + "key_code": "left_option" + } + ], + "to_if_alone": [ + { + "key_code": "j", + "modifiers": ["left_command"] + } + ], + "conditions": [ + { + "type": "frontmost_application_if", + "bundle_identifiers": ["^com\\.microsoft\\.VSCode$", "com\\.microsoft\\.VSCodeInsiders"] + } + ] + } + ] + } + ] +} From 89dc45ddd80b19313a3e6bff200e55730ee35177 Mon Sep 17 00:00:00 2001 From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com> Date: Wed, 12 Jun 2024 08:49:31 +1000 Subject: [PATCH 2/6] Added maintainers --- public/json/vs_code_left_option_hide_terminal.json | 1 + 1 file changed, 1 insertion(+) diff --git a/public/json/vs_code_left_option_hide_terminal.json b/public/json/vs_code_left_option_hide_terminal.json index 86f5429f6..d5b669bfa 100644 --- a/public/json/vs_code_left_option_hide_terminal.json +++ b/public/json/vs_code_left_option_hide_terminal.json @@ -1,5 +1,6 @@ { "title": "left option → cmd + j (VS Code → hide terminal)", + "maintainers": ["thecarlo"], "rules": [ { "description": "left option → cmd + j (VS Code → hide terminal)", From e9932638e549e50e9a6b428613ce83301483ae84 Mon Sep 17 00:00:00 2001 From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com> Date: Wed, 12 Jun 2024 08:59:09 +1000 Subject: [PATCH 3/6] Added rule to application specific group --- public/groups.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/public/groups.json b/public/groups.json index 6ec59f48d..46aabe322 100644 --- a/public/groups.json +++ b/public/groups.json @@ -526,6 +526,9 @@ { "path": "json/xcode.json" }, + { + "path": "json/vs_code_left_option_hide_terminal.json" + }, { "path": "json/vscode.json", "extra_description_path": "extra_descriptions/vscode.json.html" From 5d04f05908e3fb0a151b17c38445421917cb29d1 Mon Sep 17 00:00:00 2001 From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com> Date: Wed, 12 Jun 2024 10:16:26 +1000 Subject: [PATCH 4/6] Added author --- public/json/vs_code_left_option_hide_terminal.json | 1 + 1 file changed, 1 insertion(+) diff --git a/public/json/vs_code_left_option_hide_terminal.json b/public/json/vs_code_left_option_hide_terminal.json index d5b669bfa..56429da23 100644 --- a/public/json/vs_code_left_option_hide_terminal.json +++ b/public/json/vs_code_left_option_hide_terminal.json @@ -1,5 +1,6 @@ { "title": "left option → cmd + j (VS Code → hide terminal)", + "author": "Carlo van Wyk (https://github.com/thecarlo)", "maintainers": ["thecarlo"], "rules": [ { From 21f54db81b25363c2319e16eaed4267f7389f829 Mon Sep 17 00:00:00 2001 From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com> Date: Wed, 12 Jun 2024 10:33:35 +1000 Subject: [PATCH 5/6] Cleanup --- ...terminal.json => vs_code_left_option_toggle_terminal.json} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename public/json/{vs_code_left_option_hide_terminal.json => vs_code_left_option_toggle_terminal.json} (84%) diff --git a/public/json/vs_code_left_option_hide_terminal.json b/public/json/vs_code_left_option_toggle_terminal.json similarity index 84% rename from public/json/vs_code_left_option_hide_terminal.json rename to public/json/vs_code_left_option_toggle_terminal.json index 56429da23..47492cee0 100644 --- a/public/json/vs_code_left_option_hide_terminal.json +++ b/public/json/vs_code_left_option_toggle_terminal.json @@ -1,10 +1,10 @@ { - "title": "left option → cmd + j (VS Code → hide terminal)", + "title": "left option → cmd + j (VS Code → toggle terminal)", "author": "Carlo van Wyk (https://github.com/thecarlo)", "maintainers": ["thecarlo"], "rules": [ { - "description": "left option → cmd + j (VS Code → hide terminal)", + "description": "left option → cmd + j (VS Code → toggle terminal)", "manipulators": [ { "type": "basic", From 5ca93f60097f8d89fa31de038bac05cd01fd9e68 Mon Sep 17 00:00:00 2001 From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com> Date: Wed, 12 Jun 2024 10:36:02 +1000 Subject: [PATCH 6/6] Cleanup --- public/groups.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/groups.json b/public/groups.json index 46aabe322..dd78b92ae 100644 --- a/public/groups.json +++ b/public/groups.json @@ -527,7 +527,7 @@ "path": "json/xcode.json" }, { - "path": "json/vs_code_left_option_hide_terminal.json" + "path": "json/vs_code_left_option_toggle_terminal.json" }, { "path": "json/vscode.json",