From 90f0048180da294c51d11f86dbd8f88f0bd6d033 Mon Sep 17 00:00:00 2001
From: Carlo van Wyk <5310264+thecarlo@users.noreply.github.com>
Date: Sun, 16 Jun 2024 14:11:05 +1000
Subject: [PATCH] Disable minimising windows (#1670)
---
public/extra_descriptions/mac_osx.html | 16 +++++--
.../mac_osx_disable_cmd_h.html | 14 ------
.../mac_osx_disable_minimising_windows.html | 24 ++++++++++
public/groups.json | 8 ++--
public/json/mac_osx.json | 27 ++++++++++-
public/json/mac_osx_disable_cmd_h.json | 20 ---------
.../mac_osx_disable_minimising_windows.json | 45 +++++++++++++++++++
7 files changed, 111 insertions(+), 43 deletions(-)
delete mode 100644 public/extra_descriptions/mac_osx_disable_cmd_h.html
create mode 100644 public/extra_descriptions/mac_osx_disable_minimising_windows.html
delete mode 100644 public/json/mac_osx_disable_cmd_h.json
create mode 100644 public/json/mac_osx_disable_minimising_windows.json
diff --git a/public/extra_descriptions/mac_osx.html b/public/extra_descriptions/mac_osx.html
index cc6d45fb0..222b2189d 100644
--- a/public/extra_descriptions/mac_osx.html
+++ b/public/extra_descriptions/mac_osx.html
@@ -61,16 +61,24 @@
- Disable minimising applications
+ Disable minimising windows on Mac OSX.
- Since it's easy to accidentally minimise an application, I've disabled the cmd + h default keybinding in Mac OSX.
+ Minimising windows on OSX is annoying as the windows disappear and leads to unnecessary friction to find the windows and open them again.
- cmd + h
- keybinding is disabled
+ cmd + h (minimise the active application window)
+
+ Keybinding is disabled
+
+
+
+ cmd + option + h + m (minimise all application windows)
+
+ Keybinding is disabled
+
diff --git a/public/extra_descriptions/mac_osx_disable_cmd_h.html b/public/extra_descriptions/mac_osx_disable_cmd_h.html
deleted file mode 100644
index a16709650..000000000
--- a/public/extra_descriptions/mac_osx_disable_cmd_h.html
+++ /dev/null
@@ -1,14 +0,0 @@
-
- Disable cmd + h to prevent accidentally minimising windows.
-
-
-
-
- cmd + h
-
- Keybinding is disabled
-
-
-
diff --git a/public/extra_descriptions/mac_osx_disable_minimising_windows.html b/public/extra_descriptions/mac_osx_disable_minimising_windows.html
new file mode 100644
index 000000000..d52d6f34b
--- /dev/null
+++ b/public/extra_descriptions/mac_osx_disable_minimising_windows.html
@@ -0,0 +1,24 @@
+
+ Disable minimising windows on Mac OSX.
+
+
+
+ Minimising windows on OSX is annoying as the windows disappear and leads to unnecessary friction to find the windows and open them again.
+
+
+
+
+ cmd + h (minimise the active application window)
+
+ Keybinding is disabled
+
+
+
+ cmd + option + h + m (minimise all application windows)
+
+ Keybinding is disabled
+
+
+
diff --git a/public/groups.json b/public/groups.json
index 0151e43b6..40a69ffa8 100644
--- a/public/groups.json
+++ b/public/groups.json
@@ -1312,6 +1312,10 @@
{
"path": "json/mac_osx_double_tap_q_close_application.json"
},
+ {
+ "path": "json/mac_osx_disable_minimising_windows.json",
+ "extra_description_path": "extra_descriptions/mac_osx_disable_minimising_windows.html"
+ },
{
"path": "json/mwit-taskbar-number-launch-app.json"
},
@@ -1404,10 +1408,6 @@
"path": "json/multitouch_vi_mode.json",
"extra_description_path": "extra_descriptions/multitouch_vi_mode.json.html"
},
- {
- "path": "json/mac_osx_disable_cmd_h.json",
- "extra_description_path": "extra_descriptions/mac_osx_disable_cmd_h.html"
- },
{
"path": "json/multitouch_mouse_buttons.json",
"extra_description_path": "extra_descriptions/multitouch_mouse_buttons.json.html"
diff --git a/public/json/mac_osx.json b/public/json/mac_osx.json
index 74ae7df45..940622a21 100644
--- a/public/json/mac_osx.json
+++ b/public/json/mac_osx.json
@@ -233,7 +233,7 @@
]
},
{
- "description": "Mac OSX: disable cmd + h so that it does not minimise windows",
+ "description": "Mac OSX: disable cmd + h to prevent minimising an application window",
"manipulators": [
{
"from": {
@@ -245,6 +245,31 @@
"type": "basic"
}
]
+ },
+ {
+ "description": "Mac OSX: disable cmd + option + h + m to prevent minimising all windows",
+ "manipulators": [
+ {
+ "from": {
+ "key_code": "h",
+ "modifiers": {
+ "mandatory": ["command", "option"],
+ "optional": ["any"]
+ }
+ },
+ "type": "basic"
+ },
+ {
+ "from": {
+ "key_code": "m",
+ "modifiers": {
+ "mandatory": ["command", "option"],
+ "optional": ["any"]
+ }
+ },
+ "type": "basic"
+ }
+ ]
}
]
}
diff --git a/public/json/mac_osx_disable_cmd_h.json b/public/json/mac_osx_disable_cmd_h.json
deleted file mode 100644
index 5b2915ea3..000000000
--- a/public/json/mac_osx_disable_cmd_h.json
+++ /dev/null
@@ -1,20 +0,0 @@
-{
- "title": "Mac OSX: disable cmd + h so that it does not minimise windows",
- "maintainers": ["thecarlo"],
- "rules": [
- {
- "description": "Mac OSX: disable cmd + h so that it does not minimise windows",
- "manipulators": [
- {
- "from": {
- "key_code": "h",
- "modifiers": {
- "mandatory": ["command"]
- }
- },
- "type": "basic"
- }
- ]
- }
- ]
-}
diff --git a/public/json/mac_osx_disable_minimising_windows.json b/public/json/mac_osx_disable_minimising_windows.json
new file mode 100644
index 000000000..d894478b5
--- /dev/null
+++ b/public/json/mac_osx_disable_minimising_windows.json
@@ -0,0 +1,45 @@
+{
+ "title": "Mac OSX: disable minimising windows",
+ "maintainers": ["thecarlo"],
+ "rules": [
+ {
+ "description": "Mac OSX: disable cmd + h to prevent minimising an application window",
+ "manipulators": [
+ {
+ "from": {
+ "key_code": "h",
+ "modifiers": {
+ "mandatory": ["command"]
+ }
+ },
+ "type": "basic"
+ }
+ ]
+ },
+ {
+ "description": "Mac OSX: disable cmd + option + h + m to prevent minimising all windows",
+ "manipulators": [
+ {
+ "from": {
+ "key_code": "h",
+ "modifiers": {
+ "mandatory": ["command", "option"],
+ "optional": ["any"]
+ }
+ },
+ "type": "basic"
+ },
+ {
+ "from": {
+ "key_code": "m",
+ "modifiers": {
+ "mandatory": ["command", "option"],
+ "optional": ["any"]
+ }
+ },
+ "type": "basic"
+ }
+ ]
+ }
+ ]
+}