From 75f7146a64cff71d0247b363d5ea6e4af4988b47 Mon Sep 17 00:00:00 2001 From: Yoni Goldberg Date: Thu, 4 Apr 2024 17:54:04 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> --- .../order-service/entry-points-fastify/api/routes.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/code-templates/services/order-service/entry-points-fastify/api/routes.ts b/src/code-templates/services/order-service/entry-points-fastify/api/routes.ts index a1d756bc..8d9c0eec 100644 --- a/src/code-templates/services/order-service/entry-points-fastify/api/routes.ts +++ b/src/code-templates/services/order-service/entry-points-fastify/api/routes.ts @@ -1,4 +1,4 @@ -import { IncomingMessage, Server, ServerResponse } from 'http'; +import { IncomingMessage, Server, ServerResponse } from 'node:http'; import { TypeBoxTypeProvider } from '@fastify/type-provider-typebox'; import { Type } from '@sinclair/typebox'; import { FastifyBaseLogger, FastifyInstance } from 'fastify'; @@ -42,14 +42,15 @@ export async function routes(app: FastifyWithTypeProvider) { }, handler: async (request, response) => { logger.info( - `Order API was called to get user by id ${request.params.id}` + `Order API was called to get order by id`, {orderId: request.params.id} ); const result = await newOrderUseCase.getOrder( parseInt(request.params.id, 10) ); if (!result) { - return response.status(404).send(); + response.status(404); + return; } return result; @@ -67,9 +68,9 @@ export async function routes(app: FastifyWithTypeProvider) { }), }, handler: async (request, response) => { - logger.info(`Order API was called to delete order ${request.params.id}`); + logger.info(`Order API was called to delete order`, { orderId: request.params.id }); await newOrderUseCase.deleteOrder(parseInt(request.params.id, 10)); - response.status(204).send(); + response.status(204); }, }); }