Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when executing run.sh from wrong directory #605

Open
BenjaminRodenberg opened this issue Dec 12, 2024 · 2 comments
Open

Improve error when executing run.sh from wrong directory #605

BenjaminRodenberg opened this issue Dec 12, 2024 · 2 comments

Comments

@BenjaminRodenberg
Copy link
Member

I think for every (?) run.sh file it is necessary to run it from the folder of the participant (e.g. partitioned-heat-conduction/dirichlet-fenics). Running ./dirichlet-fenics/run.sh from partitioned-heat-conduction is incorrect and results in the error:

ERROR: Could not open requirements file: [Errno 2] No such file or directory: '../solver-fenics/requirements.txt'

Is it possible to improve this error? Basically we have to make sure that we always execute run.sh from its parent directory.

@MakisH
Copy link
Member

MakisH commented Dec 12, 2024

First of all: yes, it would be nice to catch the user mistake earlier.

From some (very short) previous research around the topic, I understood that the ways to do this in the run scripts are mostly shell-specific and not very standard. But I would be happy with any solution that passes shellcheck.

In the meantime, we have switched our scripts from sh to bash, so we have more options.

@uekerman
Copy link
Member

uekerman commented Jan 14, 2025

Side note: In the application guidelines, we (will) specify that these script are supposed to be called from the subfolders.

And we also have this in the tutorial docs already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants