Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why is margin-right: 5px being applied to buttons? #33

Open
ollieayre-oc opened this issue Jan 15, 2018 · 2 comments
Open

Question: Why is margin-right: 5px being applied to buttons? #33

ollieayre-oc opened this issue Jan 15, 2018 · 2 comments

Comments

@ollieayre-oc
Copy link

Hi

On line 309 these styles are being applied to buttons, I wonder if you could explain why these specific values are being applied?

.cleanslate button { padding: 1px 6px 2px 6px !important; margin-right: 5px !important; }

Thanks

@ddelrio1986
Copy link

That is a good question. It seems by default most browsers give buttons a margin of 0.

@premasagar
Copy link
Owner

Well noticed. I couldn't honestly say. The stylesheet arose from a combination of different browsers' default stylesheets, default styles listed on MDN and so on. The style may have been contained in one of those, or it is even possible that an opinionated style or two crept in during development, just "because it should be like that".

If you'd like to fix it, with a justification, please feel free to make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants