Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - delete password in the profile section #26

Open
prikryla opened this issue Oct 20, 2024 · 4 comments
Open

FE - delete password in the profile section #26

prikryla opened this issue Oct 20, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@prikryla
Copy link
Owner

prikryla commented Oct 20, 2024

@janmrakava IMHO there is no reason to display the actual user's password in the profile section. I'm suggesting some button that will redirect user to some form where he can change his password. WDYT? We can also implement some verification via email to confirm the edit process.

@janmrakava janmrakava added the bug Something isn't working label Oct 20, 2024
@janmrakava
Copy link
Collaborator

That's my mistake, that should be basic input with type=password, so user can just see the basic password template. But I forgot to add type, gonna fix it soon

@prikryla
Copy link
Owner Author

No worries, but still .. no need to leave it here, or..? Button for change password is enough I think.

@janmrakava
Copy link
Collaborator

Just check the Figma design, whole functionality is here. But well, maybe I can change it, im not sure, its matter of preference I guess

@prikryla
Copy link
Owner Author

I know that we have it in Figma, but think about it. If we use type=password, the password will be hidden and what's the reason to have it here? None I guess. If user wants to change password, he should be able to use some button, whatever, to redirect somewhere he can input new password and make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants