Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput: Value/Placeholder font size doesn't respect it's size variant #4851

Open
maximedegreve opened this issue Aug 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working react UI mob pair

Comments

@maximedegreve
Copy link
Contributor

maximedegreve commented Aug 15, 2024

Description

We've noticed an issue on the platform where small buttons are paired with small text inputs, the text inputs use a medium font size instead of a small font-size. This creates a mismatch in the visual hierarchy, as shown below:

Example of a list in Figma with secondary buttons. The first row has a small button with small text and the second row has a small input with medium text

Upon investigation, we found that small text fields are implemented correctly in Rails. However, in React and Figma, this implementation isn't consistent.

You can check the correct Rails implementation here: Text Field Playground.

Steps to reproduce

Go in Figma or the React playground and set the size to small. Then inspect the font-size which will indicate a medium size.

Version

Latest

Browser

Safari

@maximedegreve maximedegreve added the bug Something isn't working label Aug 15, 2024
@primer primer deleted a comment from github-actions bot Aug 15, 2024
@primer primer deleted a comment from github-actions bot Aug 15, 2024
@siddharthkp
Copy link
Member

siddharthkp commented Aug 19, 2024

@maximedegreve Should this be in primer/view_components?

I read that incorrectly, sorry!

@lesliecdubs
Copy link
Member

Sending this over to @langermank since she helps run the UI mob pair meeting on @tallys's recommendation 😄

@onehanddev
Copy link

Hi! @lesliecdubs @langermank
I’m interested in working on this bug. Is it still available for someone to take? If there are any specific details I should consider, please let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react UI mob pair
Projects
None yet
Development

No branches or pull requests

5 participants