-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TS 5.5 ${configDir}
template variable
#81
Comments
@privatenumber I'd like to create a PR for |
Yeah the tests need to be updated when you upgrade |
It seems that the latest |
Yep, it's a good thing. get-tsconfig should match this behavior and build-in this logic. |
Though |
Before, it was up to the consumer of get-tsconfig's output to determine what configs are implicitly enabled, but now get-tsconfig does it for you. In terms of behavior, there's no breaking change, but there is a breaking change in terms of API output. I don't mind doing a major release for this. |
@SukkaW I'm quite occupied with work these days but if it's a priority, I'm happy to support you to get this in. For now, we can upgrade TypeScript and suppress the extra output. Would you be willing to open a PR? |
I already had a branch going. Lemme see what I can do. Actually I suggest that we makes the tests passed first, that's to say, let's switch from |
Sounds good! |
🎉 This issue has been resolved in version 4.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@privatenumber You might want to re-open this issue. #83 only fixes the test cases are doesn't actually implement the |
See eba8538 |
Oh I missed that! |
This comment was marked as spam.
This comment was marked as spam.
This is a closed issue, please open another one. Looks like I missed rootDirs and others (declarationDir, typeRoots, baseUrl). Feel free to open a PR |
Feature request
TS 5.5 support
${configDir}
template variable. See here.Motivations
To support TS 5.5
${configDir}
template variable.Alternatives
No response
Additional context
No response
Bugs are expected to be fixed by those affected by it
Compensating engineering work financially will speed up resolution
The text was updated successfully, but these errors were encountered: